Please don't merge the dev branch into this one unless there are conflicts, when I merge this PR everything will be handled by Git automatically. Can you please reset --hard to the previous commit and then force push? This will remove the merge commit from the history.

These unnecessary merges pollute the commit history with useless commits so you should avoid them. Thanks!

I cannot approve of the changes made in the most recent 2 commits. Widgets should be customizable not through a separate menu in the app but through the widget's customization menu on the home screen.

Also, this is supposed to be a minor fix PR and we are exceeding the scope of this PR here. Please discuss with me here before making any UI changes so that you don't unknowingly spend your time on changes that I might reject. Thanks!

oh I'm so sorry I forget to check until now, I will definitely do that tomorrow, I knew a separate menu in the app is not recommended, I was just experimenting with the components, don't worry I'll try to fix things tomorrow or after tomorrow, please lemme know what you want me to change exactly , and sorry again

So I have a bit of a problem with this feature... and it's that it is really overwhelming. Choosing from so many different colors for each element is like telling the user to design the widget. IMO this is the wrong approach. Here's what I propose: We provide a list of pre-matched combinations of colors for the widgets and the user can choose one of the styles.

Why I'm proposing this is that we as enthusiasts may not understand the POV of a regular user who wouldn't even know what a "role" is or which combinations will not break the widget's contrast. We can drastically simplify the user's work here by providing a set of themes as I said. This will also simplify the code quite a bit so it's a win-win.

Also currently the default colors picked by the widget look nothing like how the widget should look if it followed the native colors. See: (what the default should be / what it actually is. The top bar isn't visible and the color is wrong). This is unrelated to the feature and it is a bug anyway.

If you agree with this, I'll do everything over the base that you have built. By the way, the database is a mess right now lol, with 4 database migrations for a single version upgrade. You should never increase the database version by more than 1 in a single user-facing update. Also, my method eliminates the need for database migrations and a separate DAO entirely.

Do let me know what you think!

We provide a list of pre-matched combinations of colors for the widgets and the user can choose one of the styles.
Why I'm proposing this is that we as enthusiasts may not understand the POV of a regular user who wouldn't even know what a "role" is or which combinations will not break the widget's contrast. We can drastically simplify the user's work here by providing a set of themes as I said. This will also simplify the code quite a bit so it's a win-win.

I actually had exactly the same thought but I insisted for a bit and decided to just maybe let the user choose whatever colors he likes

Also currently the default colors picked by the widget look nothing like how the widget should look if it followed the native colors. See: (what the default should be / what it actually is. The top bar isn't visible and the color is wrong). This is unrelated to the feature and it is a bug anyway.
For this widget exactly, I didn't tweak it too much and the defaults were picked on dark mode only, that's why it's inconsistent

You can proceed with the work, and if you need me to change anything before that, I will look into it , and thx for the clarifying over the database thing, I was honestly overwhelmed on how it works exactly, will definitely do how you said next time

thx for the clarifying over the database thing, I was honestly overwhelmed on how it works exactly, will definitely do how you said next time

No problem! I think you are very new to Android development? If so you've done a great job with it.

I will now start pushing commits to your dev branch so please don't touch it for a bit to avoid conflicts. Thanks!

thx for the clarifying over the database thing, I was honestly overwhelmed on how it works exactly, will definitely do how you said next time

No problem! I think you are very new to Android development? If so you've done a great job with it.

I will now start pushing commits to your dev branch so please don't touch it for a bit to avoid conflicts. Thanks!

Yes kind of, I started learning kotlin last year , but I used to code in java and C before that, but it didn't go far from some school projects and personal ones I didn't push into GitHub , and don't worry I ain't going to change anything ofc lol, it's not my first time on GitHub

I'm temporarily putting this PR on hold to work on the timer topics feature. I will continue working once I'm done with it because it is a highly requested feature.

Aofc no problem! I myself would need the timer topics feature these days with my exams